The Agileer - All Comments

re: The CORRECT Way to Code a Custom Exception Class

Doug Seelinger — Mon, 20 May 2013 14:37:07 GMT

@Daniel, Good point - no need for exception "properties" to be mutable in my opinion either.

@Matt, I hear you. Some of the tests are a bit overkill in my opinion, too, but I do care about whether or not the serialization is working correctly. That's what I see missing in most custom exception examples.

Should writing custom exceptions be easier? Yeah, I think so, but this is where we are today. If you have another opinion about a better way to get around all the boilerplate, I'd love to hear it!

re: The CORRECT Way to Code a Custom Exception Class

Matt — Mon, 20 May 2013 13:54:11 GMT

This is all correct and good and all. But I can't help feeling, this is all worthless boilerplate code that I don't **want** to have to write or care about.

re: The CORRECT Way to Code a Custom Exception Class

Daniel Bradley — Mon, 20 May 2013 09:05:04 GMT

Nice pointers on the serialization aspect.

The only thing I'd add to your pattern would be to aim to make the custom properties immutable where possible and set the value only via the constructor.

re: The CORRECT Way to Code a Custom Exception Class

Doug Seelinger — Sun, 19 May 2013 12:49:58 GMT

@Alex, you're right, I am pretty sloppy on the constructor tests. Over the years, I've come to believe that testing base class functionality yields minimal utility, like testing automatic properties, for example. If I'm overriding any of that base class functionality, however, I'd definitely provide more rigorous tests.

However, there is an argument to be made that merely deriving from a base class obligates you to test at least the major parts of the base class to confirm that you haven't (or won't in the future) break base class functionality (in this case Message and InnerException as you state), so I'll update the post to cover those. Thanks for the remote pair-programming help!

There is also a ResourceReferenceProperty, so we should probably go ahead and add that into the mix for the constructors to test.

re: The CORRECT Way to Code a Custom Exception Class

Alex — Sun, 19 May 2013 08:18:05 GMT

Your constructor tests are pretty bad though. Assert.IsNotNull will always return true, unless the constructor throws an exception. But you're not testing the message or inner exception are as expected.

re: The RIGHT Way to Write a Custom Exception Class

D. Chatterjee — Sat, 18 May 2013 09:04:54 GMT

Sure to help enough

re: How To Enable ActiveX Controls on Windows Server 2008

chris — Wed, 20 Feb 2013 17:37:22 GMT

...very good, thank you!

re: How To Enable ActiveX Controls on Windows Server 2008

roy s. — Wed, 13 Feb 2013 15:40:20 GMT

You are my hero!!! BIG THANKS!!

re: Task Scheduler – A Specified Logon Session Does Not Exist

Roja.Potti — Tue, 05 Feb 2013 16:19:42 GMT

Just what I am looking for. Thanks.

re: Task Scheduler – A Specified Logon Session Does Not Exist

Karl — Fri, 04 Jan 2013 12:21:47 GMT

This has bitten me twice as well and this blog posting has bailed me out each time.

Thanks, Doug!