Being Cellfish

Stuff I wished I've found in some blog (and sometimes did)

One thing you probably want to write in your code review

Change of Address
This blog has moved to

One thing you probably want to write in your code review

Rate This
  • Comments 1

Just for the record I think face to face code reviews (or pair programming) is a much better idea than sending off a code review with an electronic tool and get some feedback back. But reality is that most teams use a tool where the reviewer and reviewee doesn't necessary talk to each other, just exchange comments. A problem with all code reviews is; how do you know if the reviewer understands the code? A good reviewer always asks and asking is easier done face to face. But what if the reviewer thinks they understand but it is wrong? To handle this I learned a neat little trick from a colleague; as a reviewer you should always write a comment explaining what you think the code/change is supposed to do. Just one high level comment with a few sentences is enough.

  • Good call. I do some code reviews over email at my company, and I'm probably guilty of doing this once or twice.

Page 1 of 1 (1 items)