Code Analysis of Microsoft Assemblies [Michael Fanning]

re: Code Analysis of Microsoft Assemblies [Michael Fanning]

Vinod — Wed, 23 Jun 2004 08:38:00 GMT

Thanks a lot Jeffry. Interospection solved the issue. When will be the release for the Interospection help documentation.?

Regards,

Vinod

re: Code Analysis of Microsoft Assemblies [Michael Fanning]

Jeffrey van Gogh — Wed, 23 Jun 2004 00:32:00 GMT

sure, provided you get the basic rules running from the article, here's some sample code:

public Problem[] Check(Method method)
{
for(int i=0; i < method.Instructions.Length; i++)
{
Instruction instruction = method.Instructions[i];
switch(instruction.OpCode)
{
case OpCode.Newobj:
InstanceInitializer cons = instruction.Value as InstanceInitializer;
if (cons.DeclaringType == MyTypeThatIsNotAllowed)
{
Problems.Add(GetResolution(cons.FullName), instruction);
}
}
}
return Problems.AsArray();
}

re: Code Analysis of Microsoft Assemblies [Michael Fanning]

Vinod — Tue, 22 Jun 2004 19:45:00 GMT

Hi Jeffrey,

Is it possible for you to post a sample code on the same.

Regards,

Vinod

re: Code Analysis of Microsoft Assemblies [Michael Fanning]

Jeffrey van Gogh — Tue, 22 Jun 2004 19:23:00 GMT

Hi Vinod,

first I'd recommend to take a look at this article from MSDN Magazine: http://msdn.microsoft.com/msdnmag/issues/04/06/Bugslayer/default.aspx It talks about how to write custom fxcop rules.

Then about your specific question. I'd walk the Method.Instructions and see if you find a instruction with OpCode.Newobj that has a value that is a InstanceInitailizer of the DataAccessHelper type.

Regards,

Jeffrey

Design Guidelines

Vinod — Tue, 22 Jun 2004 16:52:00 GMT

I have a specific design rule to check in my Presentation Layer. I have to check whether any one of the development team has mistakenly created an Instance of DataAccessHelper in the Web Layer. I should be able to check even within a method whether an Instance of the DAL is created. How is it possible to write a Custom rule for such situations using FxCop?

Regards,

Vinod

Why does FxCop generate violations against itself?

overflow — Wed, 11 Feb 2004 09:45:00 GMT

FAQ: Why does FxCop generate violations against itself? [Michael Fanning]

FxCop — Wed, 11 Feb 2004 02:12:00 GMT

re: Code Analysis of Microsoft Assemblies [Michael Fanning]

Jeffrey van Gogh — Sat, 10 Jan 2004 01:15:00 GMT

Hi Eric,

FxCop does check both Design Guidelines, as well as Code-correctness issues, the ratio is about 50%-50%. You're right though that most of the issues in System.dll are Design Guidelines violations.

Regards,

Jeffrey van Gogh
FxCop Team

re: Code Analysis of Microsoft Assemblies [Michael Fanning]

Eric Newton — Fri, 09 Jan 2004 23:39:00 GMT

people relax... fxcop is a design GUIDELINES check, not neccesarily a code-correctness check.

If System.dll had 1600 true errors, do you think we'd be happy go-lucky .Net developers? or raging lunatics bent on hair pulling...

again, relax

re: Code Analysis of Microsoft Assemblies [Michael Fanning]

Jeffrey van Gogh — Fri, 09 Jan 2004 17:44:00 GMT

That address should ofcourse be: asKfxcop At Microsoft.com