Anonymous method formatting, again.

re: Anonymous method formatting, again.

Ron — Tue, 10 Aug 2004 12:44:00 GMT

I'd like to see Geoff's second formatting or your [Kevin] seventh formatting. Indenting is generally preferable to not having it. I'd also recommend having this as the default (indenting turned on).

re: Anonymous method formatting, again.

Ornus — Tue, 10 Aug 2004 03:57:00 GMT

I like #4 or #7 (depending on the length of the method body). Would prefer by default.

re: Anonymous method formatting, again.

Sean Chase — Tue, 10 Aug 2004 03:25:00 GMT

I think this is the most readable:

List<Thing> somethings = things.FindAl(delegate(Thing thing)
{
return thing.ShouldBeIncluded;
}
);

re: Anonymous method formatting, again.

Kevin Pilch-Bisson — Mon, 09 Aug 2004 17:20:00 GMT

Hi Don,

VS2003 only allows one option controlling braces, which is whether or not to put them on the next line. However, anonymous methods are a new language feature, so there isn't yet much usage to determine how to format them.

I see your point about for loops, however, what I think there is something that distinguishes anonymous methods from for loops and the like. For loops are always a statement by themselves, whereas anonymous methods are always embedded inside another statement (like a method call, or an assignment). I think the people who are requesting this option want it because they want some way to show that the anonymous method is embedded inside the other statement.

Does that make sense?

re: Anonymous method formatting, again.

Don — Mon, 09 Aug 2004 13:58:00 GMT

When I'm writing 'for' loops in VS2003, they look like your option #3. That's how I like them to look. I'm not aware of ever having messed with curly-brace-formatting options in VS, but it's certainly certainly possible that I did. Assuming there are VS2003 curly-brace-formatting options (I'm out of town with a laptop that doesn't have VS on it), I'd want VS2005 to respect the curly-brace formatting options that I set in VS2003 (which in this case would cause anonymous methods to look like method #3 for my newlining behavior). If there are no such options in VS2003, I'd want VS2005 to have defaults that are as close to VS2003 behavior as possible (which again would be #3 for people like me who use a lot of newlines).

re: Anonymous method formatting, again.

Zk — Mon, 09 Aug 2004 07:31:00 GMT

I have to sorta take back my previous answer. I didn't notice the indenting on #3. Of all the choices, I actually like that one the best. But, if I was to do it all inline (ie, have the curly brackets on the same line as the method code, I'd do something like #5. I guess that's two completely different options, and I'd be stuck formatting manually for one or the other.

Although, except for abstract properties, I almost never have curly brackets on the same line as my block code, so I guess I'd actually end up using the existing option as my default.

re: Anonymous method formatting, again.

Luc Cluitmans — Mon, 09 Aug 2004 06:40:00 GMT

Like Geoff, I think that example 3 is the clearest, with example 6 coming in second.

As far as the indent option goes: I think having more options is always better...

re: Anonymous method formatting, again.

Michael Teper — Mon, 09 Aug 2004 06:34:00 GMT

I'd prefer having the option.

re: Anonymous method formatting, again.

Hein Mulder — Mon, 09 Aug 2004 06:18:00 GMT

As a newbe, i prefer option 7.

re: Anonymous method formatting, again.

Geoff Appleby — Mon, 09 Aug 2004 05:54:00 GMT

*laughs*
Good to see you correct yourself :)
Doesn't matter to me what can and can't be done, i was just telling you what i'd prefer.
If you choose to bow down before me and accept my preferences, then that's only the world working as it should.
If you discover that you won't/can't make it happen, i'm sure the world is no worse off - so long as i can still do option 3.
Although, whatever the formatting chosen, i think it's pretty safe in assuming that people won't really care so long as there's indenting involved, and the indenting makes sense and is clearly showing what block it's encapsulating.

I prefer the option where you bow before my judgement however :)