Saw some code like this the other day. See if you can tell what’s wrong with it:
The problem is that the API function in question returned 1 when successful, 2 when successful but additional info was available, and 0 if it failed. It can get away with this because BOOL is actually an integer. In this case, the code’s equality test for TRUE caused it to fall through to its failure path when anything but 1 (TRUE) was returned, including the success-with-info return code. The API appeared to be failing but wasn’t.
Mitigations for this include:
The moral of the story is that when there’s one “false” value and multiple “true” ones, you can’t do equality comparisons with only one of the possible true values and expect reliable control flow.