TFS API: How to choose between TeamFoundationServerFactory.GetServer() and the TeamFoundationServer constructor

re: TFS API: How to choose between TeamFoundationServerFactory.GetServer() and the TeamFoundationServer constructor

curedone — Fri, 15 Sep 2006 08:52:36 GMT

Buck,

Could you clarify something for me? Let's say I use TeamFoundationServerFactory GetServer method several time with same URL. Does the internal caching result in "same" object returned?

For example, if I retrieve VersionControlServer using GetService method of TeamFoundationServer (first instance), and then hook up on VersionControlServer event, does that mean that VersionControlServer from second instance of TeamFoundationServer will have that event hook already in place?

Here is some pseudo code (wont compile :):

// first place
tfs1 = TeamFoundationServerFactory.GetServer(url);
vc1 = tfs1.GetService();
vc1.NewPendingChange += event1;

// second place
tfs2 = TeamFoundationServerFactory.GetServer(url);
vc2 = tfs2.GetService();
vc2.NewPendingChange += event1;

Thanks.

re: TFS API: How to choose between TeamFoundationServerFactory.GetServer() and the TeamFoundationServer constructor

buckh — Fri, 15 Sep 2006 16:05:07 GMT

Yes, that is correct. So long as the url is the same, the same TFS object is returned, and the event handler shown in your code will already have been added (vc2 and vc1 reference the same VersionControlServer object).

Note that it's literally requires the URL to match to get the same object. If you provide an URL using the name and then specify an URL using the IP address, you won't get the same object.

Buck

VSTS Links - 09/15/2006

Team System News — Fri, 15 Sep 2006 16:10:48 GMT

D'Arcy Lussier on Storyboarding for Team System. Rob Caron talks about it as well.

Tan on Customizing...

WorkItemTracking object model primer

Naren's Blog — Fri, 15 Sep 2006 19:44:38 GMT

For those who never used work item tracking object model and want to start:&nbsp;I saw a nice post that...

re: TFS API: How to choose between TeamFoundationServerFactory.GetServer() and the TeamFoundationServer constructor

Ravi Terala — Fri, 15 Sep 2006 22:22:09 GMT

I recommand the obtaining services from TFS OM for all services except the WorkItemStore. It is not thread safe, where as all other services you obtain from TFS OM are. To work around this issue, create a new WorkItemStore object and pass the credentials that you get from the TFS OM.

re: TFS API: How to choose between TeamFoundationServerFactory.GetServer() and the TeamFoundationServer constructor

buckh — Tue, 19 Sep 2006 06:22:32 GMT

Ravi, while that may be true (I don't remember -- there were changes made to address at least some of the issues), it only matters when making calls from multiple threads. Folks writing single-threaded apps certainly don't have to worry about it and can get the WorkItemStore object via the usual TeamFoundationServer.GetService() method.

Buck

re: TFS API: How to choose between TeamFoundationServerFactory.GetServer() and the TeamFoundationServer constructor

J Sawyer — Tue, 01 Dec 2009 19:22:35 GMT

Don't call Dispose() on the TeamFoundationServer object that you get from the TeamFoundationServerFactory. Because it's the same instance for each URL, this will result in the cached instance being disposed and causing some mysterious errors; any call to GetService() will raise a NullReferenceException. There don't seem to be any checks in the TFS object to see if it has been disposed so it won't throw an ObjectDisposedException.

re: TFS API: How to choose between TeamFoundationServerFactory.GetServer() and the TeamFoundationServer constructor

buckh — Wed, 02 Dec 2009 04:23:48 GMT

J Sawyer, yes, that is a good point.

Buck