T4MVC 2.2 update: Routing, Forms, DI container, fixes

re: T4MVC 2.2 update: Routing, Forms, DI container, fixes

eric hexter — Wed, 01 Jul 2009 03:06:15 GMT

The protected constructor is a very interesting approach. Now I have to pull it down and do some testing around my container of choice.. StructureMap

re: T4MVC 2.2 update: Routing, Forms, DI container, fixes

Christian — Wed, 01 Jul 2009 09:43:21 GMT

hi david,

the protected constructor fixed the problem for me. (I'm using StructureMap) THANK YOU!

but why do even create this constructor with your dummy-parameter? my workaround yesterday was to just remove this one and make sure that there's always a default constructor. (I think this is done by your template anyway)

StructureMap for example always calls the constructor with most parameters, so this already fixes the problem.

thanks for working on this,

christian

re: T4MVC 2.2 update: Routing, Forms, DI container, fixes

Christian — Wed, 01 Jul 2009 10:09:51 GMT

the ExecuteResult()-method of your ControllerActionCallInfo class should not throw a "NotImplementedException" because ReSharper for example shows this as an open entry in the TODO-list. I think it would be better if you throw a "NotSupportedException".

re: T4MVC 2.2 update: Routing, Forms, DI container, fixes

Richard Kimber — Wed, 01 Jul 2009 14:30:31 GMT

This is a really useful template, it has become an integral part of my current project. Thanks for sharing.

re: T4MVC 2.2 update: Routing, Forms, DI container, fixes

Anthony — Wed, 01 Jul 2009 15:21:20 GMT

Love the new strongly typed support for MapRoute...

My only concern is that when one uses "MVC.Home.Index()" what this does is not 100% clear to a ready who doesn't know about the templates or how they work. As in when a user sees "MVC.SomthingOrOther", the MVC doesn't mean much to me.

What this template is all about and the fluid interface it generates is strongly typed names/references. So couldn't we come up with something a little more suggestive than just "MVC" that helps the user out a little more like "RouteFor.SomthingOrOther"???

Now in reality it doest have to be " RouteFor ", but if someone saw RouteFor.Home.Index() vs. MVC.Home.Index() it might be a little more clear about what the intending usage is in a given scenario.

I just think there must be a better name than just MVC that helps describe to the user whats going on.

re: T4MVC 2.2 update: Routing, Forms, DI container, fixes

Hien Khieu — Wed, 01 Jul 2009 20:32:01 GMT

David,

I am trying to use your latest T4MVC template with my mvc project and I get this error. Please help.

Error 1 Running transformation: System.EntryPointNotFoundException: Entry point was not found.

at VisualSVN.VS.Interop.NativeExtenderCallback.OnQueryEditFiles(UInt32 rgfQueryEdit, String[] rgpszMkDocuments, UInt32* pfEditVerdict, UInt32* prgfMoreInfo, Boolean* skipOriginal)

at VisualSVN.VS.Interop.NativeExtender.OnQueryEditFiles(NativeExtender* , UInt32 rgfQueryEdit, Int32 cFiles, UInt16** rgpszMkDocuments, UInt32* rgrgf, __MIDL___MIDL_itf_ivsqueryeditquerysave2_0000_0001* rgFileInfo, UInt32* pfEditVerdict, UInt32* prgfMoreInfo, Boolean* skipOriginal)

at EnvDTE80.CodeClass2.set_ClassKind(vsCMClassKind Kind)

at Microsoft.VisualStudio.TextTemplating984425EEA278851503849A871981DA21.GeneratedTextTransformation.ProcessControllerTypesInNamespace(CodeNamespace ns) in e:\Development\CSharp\MVC\MVCExperiment\MVCExperiment\Mvc-CodeGen.tt:line 401

at Microsoft.VisualStudio.TextTemplating984425EEA278851503849A871981DA21.GeneratedTextTransformation.ProcessControllersRecursive(ProjectItem projectItem) in e:\Development\CSharp\MVC\MVCExperiment\MVCExperiment\Mvc-CodeGen.tt:line 381

at Microsoft.VisualStudio.TextTemplating984425EEA278851503849A871981DA21.GeneratedTextTransformation.ProcessControllersFolder(Project project) in e:\Development\CSharp\MVC\MVCExperiment\MVCExperiment\Mvc-CodeGen.tt:line 366

at Microsoft.VisualStudio.TextTemplating984425EEA278851503849A871981DA21.GeneratedTextTransformation.PrepareDataToRender(TextTransformation tt) in e:\Development\CSharp\MVC\MVCExperiment\MVCExperiment\Mvc-CodeGen.tt:line 306

at Microsoft.VisualStudio.TextTemplating984425EEA278851503849A871981DA21.GeneratedTextTransformation.TransformText() in e:\Development\CSharp\MVC\MVCExperiment\MVCExperiment\Mvc-CodeGen.tt:line 96 E:\Development\CSharp\MVC\MVCExperiment\MVCExperiment\Mvc-CodeGen.tt 1 1

re: T4MVC 2.2 update: Routing, Forms, DI container, fixes

Anthony — Thu, 02 Jul 2009 00:46:08 GMT

Just another quick comment. The Members and Classes that you add to the partial class of each controller (with the exception of RedirectToAction), why wouldn't you you put them into the sub type "T4MVC_xyz" that you generate for a given controller and change the static reference in the MVC class to "public static T4MVC_SquadProfileController = new T4MVC_SquadProfileController();"?

Just a thought.

re: T4MVC 2.2 update: Routing, Forms, DI container, fixes

davidebb — Thu, 02 Jul 2009 00:59:35 GMT

Christian: we need the dummy ctor because if the Controller already has a default ctor, it may have logic we don't want to execute. So I guess technically, we only need the Dummy when there is already an explicit default ctor, so we could optimize that a bit.

re: T4MVC 2.2 update: Routing, Forms, DI container, fixes

davidebb — Thu, 02 Jul 2009 01:00:59 GMT

Christian, new build 2.2.01 on CodePlex throws NotSupportedException as you suggest. Thanks!

re: T4MVC 2.2 update: Routing, Forms, DI container, fixes

davidebb — Thu, 02 Jul 2009 01:06:18 GMT

Anthony: I agree that the syntax on routes doesn't make it super clear what it's doing. What's tricky is that 'MVC.Home.Index()' is the standard syntax T4MVC to encapsulate an action call with params, so it looks the same here as in ActionLink, RedirectToAction, ...

Of course, we can change the MVC prefix if we find a better one, but it would be used in those other places as well.

And finally, we could rename the MapRoute() extension method to something like MapRouteToController() if we think that's better.

re: T4MVC 2.2 update: Routing, Forms, DI container, fixes

davidebb — Thu, 02 Jul 2009 01:10:09 GMT

Anthony: I actually started out this way, with new members added in the derived class. However, I found two reasons to do it as I did:

1. I wanted 'Go To Definition' on MVC.Home.Index() to go to the user's Index method, and not the generated derived method.

2. Having it on the base lets your shorten MVC.Dinner.Views.InvalidOwner to simply Views.InvalidOwner when writing code in the Dinners controller.

re: T4MVC 2.2 update: Routing, Forms, DI container, fixes

davidebb — Thu, 02 Jul 2009 01:24:41 GMT

Hien Khieu: see my reply in the other post.

re: T4MVC 2.2 update: Routing, Forms, DI container, fixes

Richard Kimber — Thu, 02 Jul 2009 16:22:25 GMT

Hi,

I made the following changes at line 282 to get the code to compile with FileResult.

<# foreach (string resultType in ActionResultTypes) { #>

[CompilerGenerated]

public class T4MVC_<#= resultType #>: <#= resultType #>, IT4MVCActionResult {

public T4MVC_<#= resultType #>(string controller, string action) <# if (resultType == "FileResult") { #>: base("")<# } #> {

this.InitMVCT4Result(controller, action);

}

public override void ExecuteResult(ControllerContext context) {

throw new NotSupportedException();

}

public string Controller { get; set; }

public string Action { get; set; }

public RouteValueDictionary RouteValues { get; set; }

<# if (resultType == "FileResult") { #>

protected override void WriteFile(HttpResponseBase response) {

throw new NotImplementedException();

}

<# } #>

}

<# } #>

re: T4MVC 2.2 update: Routing, Forms, DI container, fixes

davidebb — Fri, 03 Jul 2009 11:34:58 GMT

Richard: I just fixed this issue in build 2.2.02 on CodePlex. Thanks!

WebForms

Mark Leistner — Thu, 09 Jul 2009 22:55:38 GMT

How difficult would it be to add support for ASP.Net WebForms pages as well, similar to how static content files are stored under Links.

Many projects I work on are slowly migrating to MVC and will contain both WebForms and MVC for the foreseable future. I'd love to be able to reference the files as Pages.Home_aspx instead of "~/Home.aspx".

re: T4MVC 2.2 update: Routing, Forms, DI container, fixes

Kiran — Sat, 11 Jul 2009 00:18:07 GMT

David,

This doesn't work if the controllers are in a different assembly

re: T4MVC 2.2 update: Routing, Forms, DI container, fixes

davidebb — Sat, 11 Jul 2009 02:34:18 GMT

Mark Leistner: that's an interesting idea. I'll put that on the list of future scenarios to look at.