FAQ: What exception should I throw instead of the reserved exceptions that DoNotRaiseReservedExceptionTypes warns against?

re: FAQ: What exception should I throw instead of the reserved exceptions that DoNotRaiseReservedExceptionTypes warns against?

PeterI — Tue, 23 Jan 2007 14:16:36 GMT

Hmm I'm not sure I understand the IndexOutOfRange one, it seems like a perfect match (or is this a case where matching the rest of the framework is better)

re: FAQ: What exception should I throw instead of the reserved exceptions that DoNotRaiseReservedExceptionTypes warns against?

Jarle Nygård — Tue, 23 Jan 2007 17:05:58 GMT

Nice! Thnx for this! :)

re: FAQ: What exception should I throw instead of the reserved exceptions that DoNotRaiseReservedExceptionTypes warns against?

David M. Kean — Tue, 23 Jan 2007 18:34:11 GMT

IndexOutOfRangeException is an exception that should be only thrown by the runtime when an index used to access an element is outside of the bounds of the array. To be consistent with the other .NET Framework classes (such as ArrayList, List<T>, Collection<T>, etc), you should throw ArgumentOutOfRangeException.

Wondering which exception type to throw?

Jeff Stong — Wed, 24 Jan 2007 04:44:26 GMT

Wondering which exception type to throw rather than the too general System.Exception? Find some...

re: FAQ: What exception should I throw instead of the reserved exceptions that DoNotRaiseReservedExceptionTypes warns against?

PeterI — Wed, 24 Jan 2007 19:34:28 GMT

Thanks for that, perhaps you should kick the MSDN doc folks and get that stuck on the documentation page.

re: FAQ: What exception should I throw instead of the reserved exceptions that DoNotRaiseReservedExceptionTypes warns against?

David M. Kean — Wed, 24 Jan 2007 20:08:43 GMT

Peter,

Thanks for the suggestion. We're working at the moment on making the docs better - expect to see information such as above, included for Orcas.

Regards

David

re: FAQ: What exception should I throw instead of the reserved exceptions that DoNotRaiseReservedExceptionTypes warns against?

Kevin Westhead — Thu, 25 Jan 2007 00:47:39 GMT

Shouldn't it be ArgumentOutOfRangeException for enums as well? This was mentioned in the comments of an earlier Enum design guideline (see http://blogs.msdn.com/kcwalina/archive/2004/05/18/134208.aspx), but perhaps best practice has changed since then? It certainly seems like most APIs outside of Windows Forms use ArgumentOutOfRangeException.

re: FAQ: What exception should I throw instead of the reserved exceptions that DoNotRaiseReservedExceptionTypes warns against?

David M. Kean — Thu, 25 Jan 2007 01:33:49 GMT

Kevin,

Good spotting. However, if you look at Brad's annotation further down the page you will see that he is throwing an InvalidEnumArgumentException.

I've actually explained the reason behind these contradictions in a Community content block at the bottom of the docs on InvalidEnumArgumentException, which I will re-post here:

Unfortunately, as InvalidEnumArgumentException is defined in System.dll and not mscorlib.dll, the later does not throw it when an invalid enum argument is passed to a member, but instead throws ArgumentException or ArgumentOutOfRangeException. This inconsistancy however, usually does not present a problem, as this exception, when thrown, typically indicates a bug in the caller and is rarely caught within a catch clause.

strange 'string' to Textbox conversion error, tips on Code Analysis, what exception to raise in your app

.NET 2.0 — Sun, 28 Jan 2007 19:46:41 GMT

The Confusing "Cannot implicitly convert type 'string' to 'System.Web.UI.WebControls.TextBox'" Compilation

re: FAQ: What exception should I throw instead of the reserved exceptions that DoNotRaiseReservedExceptionTypes warns against?

Mitch Wheat — Tue, 30 Jan 2007 06:18:29 GMT

Nice one David!

How to Design Exception Hierarchies

The Visual Studio Code Analysis Team Blog — Wed, 31 Jan 2007 08:17:18 GMT

Krzysztof Cwalina, owner of the Framework Design Guidelines , has written a great post on How to Design

How to Create Custom Code Analysis Rules for VSTS 2005

Tim McCarthy's Blog — Wed, 14 Feb 2007 00:52:26 GMT

How to Create Custom Code Analysis Rules for VSTS 2005

Tim McCarthy's Blog — Wed, 14 Feb 2007 10:21:14 GMT

FxCop backlog themes: Exceptions

I may have joined the wrong side — Sat, 05 May 2007 19:48:02 GMT

Since I started monitoring traffic on this blog a little more closely about a week ago, I had the unexpected