Free the SPWeb!

re: Free the SPWeb!

Matt Collinge — Tue, 06 Nov 2007 18:07:50 GMT

Very enlightening!! Shame the WSS developers don't follow this 'Best Practice'! I had some messages appearing in the trace log: An SPRequest object was not disposed before the end of this thread. To avoid wasting system resources, dispose of this object or its parent (such as an SPSite or SPWeb) as soon as you are done using it.

Turns out that the SPListEventProperties object creates an SPWeb object but never disposes of it!

It has a Property Web (courtesy of Lutz Roeder's Reflector):

public SPWeb Web

{

get

{

if (this.m_web == null)

{

while (this.WebUrl != null)

{

this.m_web = new SPSite(this.WebUrl).OpenWeb();

break;

}

return this.m_web;

}

Shouldn't SPListEventProperties implement IDispose?

re: Free the SPWeb!

drudolph — Fri, 28 Dec 2007 19:04:31 GMT

I'm getting the "An SPRequest object was not disposed before the end of this thread" message. However, it looks like the allocation spot is not in my code:

This SPRequest was allocated at at Microsoft.SharePoint.Library.SPRequest..ctor() at Microsoft.SharePoint.SPGlobal.CreateSPRequestAndSetIdentity(Boolean bNotGlobalAdminCode, String strUrl, Boolean bNotAddToContext, Byte[] UserToken, Boolean bIgnoreTokenTimeout, Boolean bAsAnonymous) at Microsoft.SharePoint.SPWeb.InitializeSPRequest() at Microsoft.SharePoint.SPWeb.EnsureSPRequest() at Microsoft.SharePoint.SPWeb.get_Request() at Microsoft.SharePoint.SPListItemCollection.EnsureLis...

12/28/2007 08:23:51.65* w3wp.exe (0x1A10) 0x0CCC Windows SharePoint Services General 8l1n High ...tItemsData() at Microsoft.SharePoint.SPListItemCollection.Undirty() at Microsoft.SharePoint.SPBaseCollection.System.Collections.IEnumerable.GetEnumerator() at MYCODE"

Where MYCODE is a code block that is looping (foreach) through an SPList.Item collection, hence the GetEnumerator call SPBaseCollection is making above.

I get the list whose items I am looping through from code like:

using (SPSite site = new SPSite(siteURL))

{

using (SPWeb web = site.OpenWeb())

{

return web.Lists[listName];

}

Is this OK? Is there anything I can do prevent this error?

re: Free the SPWeb!

jeromeL — Fri, 15 Feb 2008 17:16:03 GMT

using (SPSite site = new SPSite(siteURL))

{

using (SPWeb web = site.OpenWeb())

{

return web.Lists[listName];

}

this code is not good at all since your method return a splist, which is dependent of your spweb and spsite and will prevent them from being disposed, or you'll have error as the parent object has been freed from memory

you have to do all you operations on your list before you can dispose the web and site objects

re: Free the SPWeb!

Sanjay — Mon, 21 Apr 2008 16:37:46 GMT

This is my first comments Ilike these are all great story.

re: Free the SPWeb!

PD — Thu, 26 Jun 2008 19:12:43 GMT

Nice blog! Thanks for posting it.

re: Free the SPWeb!

Craig — Thu, 04 Jun 2009 14:54:54 GMT

Nice post.

By far the best posting I have seen on how to correctly dispose of sharepoint objects is at:

http://blogs.msdn.com/rogerla/archive/2008/02/12/sharepoint-2007-and-wss-3-0-dispose-patterns-by-example.aspx

re: Free the SPWeb!

Tj — Tue, 14 Jul 2009 12:41:09 GMT

Hi,

I hav'nt used any code. All I have done is just creating a site and adding some web parts to it. Then I got the error message "Trying to use the SPWeb object that has been disposed!!!" can someone explain this...

Thank You.