Clearest code challenge

re: Clearest code challenge

Derek LaZard — Sat, 20 Mar 2004 19:47:00 GMT

The following info will be needed in the equation:

1) FormDimensions
2) ButtonDimensions

re: Clearest code challenge

DarthPedro — Sat, 20 Mar 2004 20:37:00 GMT

Assuming that this is the Form and button sizes have already been set...

private const int Size buttonMargin = new Size(12, 12);

this._buttonCancel.Location.X = this.ClientRectangle.Right - buttonMargin.Width - this._buttonCancel.Width;
this._buttonCancel.Location.Y =
this.ClientRectangle.Bottom - buttonMargin.Height - this._buttonCancel.Height;

this._buttonOK.Location.X = this._buttonCancel.Location.X - buttonMargin.Width - this._buttonOK.Width;
this._buttonOK.Location.Y = this.ClientRectangle.Bottom - buttonMargin.Height - this._buttonOK.Height;

re: Clearest code challenge

Panos Theofanopoulos — Sat, 20 Mar 2004 21:26:00 GMT

protected override void OnSizeChanged(EventArgs e) {
base.OnSizeChanged (e);
//instead of ctor put your code with layout logic here
}

btw why the heck VS auto completes using base.OnSizeChanged (e);
with a space after the method ?
nobody writes this way, not even MS :)

re: Clearest code challenge

RichB — Sun, 21 Mar 2004 00:01:00 GMT

Isn't the Location X and Y immutable? I thought you had to create a new Point() class every time. Apart from that, my code would take the same form as DarthPedro's code.

re: Clearest code challenge

Jay Bazuzi [MS] — Sun, 21 Mar 2004 02:49:00 GMT

Rich is right that the Location property is immutable, so you can't modify X & Y directly & must create a new object to replace it.

I'm assuming that correctness isn't the hard part here. I assume that most developers can solve the problem of placing the controls correctly. The challenge is *clarity*.

re: Clearest code challenge

Jay Bazuzi [MS] — Sun, 21 Mar 2004 03:09:00 GMT

Panos: In Whidbey we've implemented a powerful & flexible formatting engine. There is an option for this exact case. (At one point we had 90 options!)

It turns out that any time you say "No one formats there code like XXX", you'll hear from someone who does. For example, *I* like a space between the method name and the open paren.

re: Clearest code challenge

Thomas Eyde — Sun, 21 Mar 2004 05:24:00 GMT

int margin = 12;

ControlMover okMover = new ControlMover(_buttonOK, this.ClientSize, margin);
okMover.MoveLeft();
okMover.MoveUp();

ControlMover cancelMover = new ControlMover(_buttonCancel, _buttonOK.Location, margin);
cancelMover.MoveLeft();

class ControlMover
{
Control _control;
int _margin;

public ControlMover(Control c, Point location, int margin)
{
_margin = margin;
_control = c;
_control.Location = location;
}

public ControlMover(Control c, Size location, int margin)
: this (c, new Point(location), margin)
{
}

public void MoveLeft(int delta)
{
_control.Location = Offset(- delta - _margin, 0);
}

Point Offset(int deltaX, int deltaY)
{
Point location = _control.Location;
location.Offset(deltaX, deltaY);
return location;
}

public void MoveLeft()
{
MoveLeft(_control.Width);
}

public void MoveUp(int delta)
{
_control.Location = Offset(0, - delta - _margin);
}

public void MoveUp()
{
MoveUp(_control.Height);
}
}

re: Clearest code challenge

pin17931 — Sun, 21 Mar 2004 16:24:00 GMT

private const int Margin = 12;

int x = ClientRectangle.Right - Margin;
int y = ClientRectangle.Bottom + Margin + _buttonCancel.Height;

this._buttonCancel = New Point(x,y)

x -= buttonCancel.Width - Margin;
this._buttonOK = new Point(x,y)

re: Clearest code challenge

Tene — Sun, 21 Mar 2004 17:22:00 GMT

// put the Cancel button in the lower right corner

// put the Ok button at the left of the Cancel button

From that, no matter how crap the code is, if the developer can read a comment, he'll be able to get the idea beyond the code. And unless the dev made the exact opposite challenge anyone should be even able to find the code clear.

By the way: I won't put the code in OnSizeChanged, I'll simply use what winforms give us: anchoring.

// blue cheese

jaybaz_MS's WebLog — Mon, 22 Mar 2004 22:37:00 GMT

// blue cheese

jaybaz_MS's WebLog — Mon, 22 Mar 2004 22:37:00 GMT

YetAnotherAttempt

Louis Zelus — Wed, 24 Mar 2004 18:59:00 GMT

Private Sub JayBazExample_Load(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles MyBase.Load
_buttonCancel.PositionBottomRight(12, 12)
_buttonOK.PositionLeftOf(_buttonCancel, 12)
End Sub
End Class

Public Class PositionalButton
Inherits Button

Public Sub PositionBottomRight(ByVal VerticalPadding As Int32, ByVal HorizontalPadding As Int32)
Top = Me.Parent.ClientSize.Height - Me.Height - VerticalPadding
Left = Me.Parent.ClientSize.Width - Me.Width - HorizontalPadding
End Sub

Public Sub PositionLeftOf(ByVal Target As Button, ByVal VerticalPadding As Int32)
Top = Target.Top
Left = Target.Left - Me.Width - VerticalPadding
End Sub

End Class

re: Clearest code challenge

Alfred Gary Myers Jr. — Wed, 24 Mar 2004 22:12:00 GMT

_buttonCancel.Top = ClientSize.Height - _buttonCancel.Height - 12;
_buttonCancel.Left = ClientSize.Width - _buttonCancel.Width - 12;

_buttonOK.Top = _buttonCancel.Top;
_buttonOK.Left = _buttonCancel.Left - _buttonOK.Width - 12;

re: Clearest code challenge

Alfred Gary Myers Jr. — Wed, 24 Mar 2004 22:16:00 GMT

_buttonCancel.Location = new Point(ClientSize.Width - _buttonCancel.Width - 12, ClientSize.Height - _buttonCancel.Height - 12);
_buttonOK.Location = new Point(_buttonCancel.Left - _buttonOK.Width - 12, _buttonCancel.Top);

re: Clearest code challenge

Michal Chaniewski — Thu, 25 Mar 2004 16:41:00 GMT

For me the clearest solution is simple

private void PlaceButtons()
{
const int BUTTON_MARGIN = 12;

_buttonCancel.Location = new System.Drawing.Point(
this.ClientRectangle.Width - _buttonCancel.Width - BUTTON_MARGIN,
this.ClientRectangle.Height - _buttonCancel.Height - BUTTON_MARGIN);
_buttonOK.Location = new System.Drawing.Point(
this.ClientRectangle.Width - _buttonCancel.Width - _buttonOK.Width - 2*BUTTON_MARGIN,
this.ClientRectangle.Height - _buttonOK.Height - BUTTON_MARGIN);

_buttonCancel.Anchor = AnchorStyles.Bottom | AnchorStyles.Right;
_buttonOK.Anchor = AnchorStyles.Bottom | AnchorStyles.Right;
}

Comments on an Answer to a Clearest Code Challenge

the1's WebLog — Sat, 27 Mar 2004 04:22:00 GMT

Comments on an Answer to a Clearest Code Challenge

the1's WebLog — Sat, 27 Mar 2004 08:41:00 GMT

jaybaz MS WebLog Clearest code challenge | Green Tea Fat Burner

jaybaz MS WebLog Clearest code challenge | Green Tea Fat Burner — Tue, 09 Jun 2009 22:32:18 GMT

PingBack from http://greenteafatburner.info/story.php?id=3736