ASP.NET 4.0 Enhancements to Data Controls

re: ASP.NET 4.0 Enhancements to Data Controls

Richard — Mon, 29 Jun 2009 19:14:01 GMT

Excellent news!

Presumably the RenderTable property will be extended to the Login, PasswordRecovery and ChangePassword controls? The control adapter to remove the unit table from these controls under .NET 2 / 3.5 is a mess of reflection calls.

re: ASP.NET 4.0 Enhancements to Data Controls

MikeOrmond — Tue, 30 Jun 2009 11:28:34 GMT

Hi Richard. I've just checked and that's not the case in the beta build. Of course that may change between now and release. Mike

re: ASP.NET 4.0 Enhancements to Data Controls

Richard — Tue, 30 Jun 2009 15:31:00 GMT

I hope it does. For reference, this is the simplest workaround I could come up with:

using System;

using System.Reflection;

using System.Security;

using System.Security.Permissions;

using System.Web;

using System.Web.UI;

using System.Web.UI.Adapters;

using System.Web.UI.WebControls;

namespace Web.UI.Adapters

{

using FCCSS = Func<ControlCollection, string, string>;

[AspNetHostingPermission(SecurityAction.LinkDemand, Level = AspNetHostingPermissionLevel.Minimal)]

public sealed class ChangePasswordAdapter : ControlAdapter

{

private static readonly Type ContainerType = FindContainerType();

private static readonly FCCSS SetCollectionReadOnly = FindSetCollectionReadOnlyMethod();

private static Type FindContainerType()

{

Assembly asm = typeof(HttpContext).Assembly;

return asm.GetType("System.Web.UI.WebControls.LoginUtil+GenericContainer`1", false, true);

}

private static FCCSS FindSetCollectionReadOnlyMethod()

{

const BindingFlags flags = BindingFlags.Instance | BindingFlags.NonPublic;

MethodInfo method = typeof(ControlCollection).GetMethod("SetCollectionReadOnly",

flags, null, new Type[] { typeof(string) }, null);

if (null == method) return null;

return (FCCSS)Delegate.CreateDelegate(typeof(FCCSS), method, true);

}

protected override void Render(HtmlTextWriter writer)

{

if (null != ContainerType && null != SetCollectionReadOnly)

{

Control control = this.Control;

if (control is ChangePassword || control is Login || control is PasswordRecovery)

{

// NB: Setting the render method delegate sets the child control

// collection to read-only. Since the login controls create their

// child controls from the render method, we need to clear the

// read-only flag to avoid an exception.

control.SetRenderMethodDelegate(RenderChildren);

SetCollectionReadOnly(control.Controls, null);

}

base.Render(writer);

}

private static void RenderChildren(HtmlTextWriter output, Control container)

{

if (container.HasControls())

{

foreach (Control child in container.Controls)

{

if (null != child && child.Visible)

{

Type childType = child.GetType().BaseType;

if (childType.IsGenericType && ContainerType == childType.GetGenericTypeDefinition())

{

if (child.HasControls())

{

foreach (Control c in child.Controls)

{

c.RenderControl(output);

}

else

{

child.RenderControl(output);

}

re: ASP.NET 4.0 Enhancements to Data Controls

MikeOrmond — Tue, 30 Jun 2009 15:52:14 GMT

What's the limitation / reason you're not just using the CSS Friendly Control Adapters implementation? Mike

re: ASP.NET 4.0 Enhancements to Data Controls

Richard — Tue, 30 Jun 2009 20:34:08 GMT

The last time I looked at the CSS Friendly adapters for the Login, ChangePassword and PasswordRecovery controls, they seemed to be completely replicating or replacing the functionality of the controls they were adapting. I just wanted something that would remove the unit table from the control, whilst leaving the rest of the functionality intact. ~1200 lines of C# plus nearly 100 lines of javascript seems a bit overkill for that!

I've posted a suggestion on Connect for the RenderTable property to be added to these controls:

https://connect.microsoft.com/VisualStudio/feedback/ViewFeedback.aspx?FeedbackID=471384

re: ASP.NET 4.0 Enhancements to Data Controls

richard_deeming — Mon, 20 Jul 2009 15:14:29 GMT

I've just been notified that this option will be extended to the security controls for beta 2:

"We are providing the option to remove wrapping outer table that you see on all the controls you listed in .NET 4. FormView was all that we shipped in Beta one but the following beta release will add this to the other controls as well."